Ticket #169 (closed defect: fixed)

Opened 06/13/08 10:17:29 (4 months ago)

Last modified 07/15/08 13:38:03 (3 months ago)

Plogger creates new album with same name as existing one

Reported by: dime Owned by: sidtheduck
Priority: highest Milestone: 1.0
Component: General Version:
Severity: major Keywords:
Cc: tracs@…

Description (last modified by sidtheduck) (diff)

I already reported this on forum, so this is copy of that post.

If I have collection called “My Pictures” and in it album “Vacation”, I can still create new album in this collection with name “Vacation” and Plogger won't show me any error or message that album with that name already exists! It will put files in same folder as for first album, but it will show them in separate albums. Actually, you can see pictures from second album only in Manage tab, since it generates same URLs for both albums (with cruft-free turned on), but on click opens firstly created. In collection view it generates thumbnails for both albums and numbers for both of them, but with same URL, and, as I said, it lead to only first one.

Attachments

duplicate_album_fix.patch (20.0 kB) - added by sidtheduck 3 months ago.

Change History

Changed 07/08/08 11:11:33 (3 months ago) by sidtheduck

  • owner changed from mike to sidtheduck
  • status changed from new to assigned

I'll take a look at this. I should be able to use similar code as the add_collections and move_collections functions that check to make sure that particular album path is not duplicated.

Changed 07/10/08 16:46:44 (3 months ago) by sidtheduck

Changed 07/10/08 16:49:13 (3 months ago) by sidtheduck

  • keywords has-patch needs-testing added

See attached file duplicate_album_fix.patch for r556 as a solution to this problem. It adds a check for duplicate albums and enhances the similar check for duplicate collections. All error messages should be included as well. Let me know what you all think.

Changed 07/15/08 03:27:57 (3 months ago) by _Eric_

  • description modified (diff)

Tested and patch works. We should remember that it creates new strings for localization.

Changed 07/15/08 13:38:03 (3 months ago) by sidtheduck

  • keywords has-patch needs-testing removed
  • status changed from assigned to closed
  • resolution set to fixed
  • description modified (diff)

Thanks for testing Eric. I committed the patched code in r558.

Note: See TracTickets for help on using tickets.