Ticket #175 (closed defect: fixed)

Opened 7 weeks ago

Last modified 5 weeks ago

Revision 550 breaks translation

Reported by: Eric Owned by: _Eric_
Priority: normal Milestone: 1.0
Component: i18n Version: 1.0b3
Severity: major Keywords:
Cc:

Description (last modified by _Eric_) (diff)

The plog_tr calls seem to have disappeared from the theme files in revision 550. This means translation strings aren't being read in those places.

Example from 549:

print "<p class='errors'>" . plog_tr('Comment did not post!  Please fill in required fields.') . "</p>";

Same bit from 550:

print "<p class='errors'>Comment did not post! Please fill in required fields.</p>"; }}}

Change History

Changed 6 weeks ago by _Eric_

  • owner changed from mike to _Eric_
  • status changed from new to assigned
  • description modified (diff)

Changed 6 weeks ago by sidtheduck

  • description modified (diff)

The r549 translatable theme files should be back in the SVN as of r552. I had time to clean the "Air" theme, but the others still need cleaning / formatting. I can try to get to it, or you can finish it up _Eric_.

Let me know. :D

Changed 6 weeks ago by _Eric_

  • description modified (diff)

Clean up code or clean up as in #133?

Changed 6 weeks ago by sidtheduck

  • description modified (diff)

Just a general clean up. Most of the #133 items should be correct: images all moved to individual theme folders (but not "customized" for each theme), CSS paths *should* be correct, etc.

Mostly what I'm talking about is cleaning up the output HTML (use real tabs instead of spaces, UNIX line endings, cleaning end of line whitespace, verify XHTML compliancy). I believe Kim mentioned something about this in an email to me.

Changed 5 weeks ago by kimparsell

  • version set to 1.0b3

All 3 themes should have all of the translation hooks in place now. I'm assuming we can close this ticket?

Changed 5 weeks ago by _Eric_

  • status changed from assigned to closed
  • resolution set to fixed
  • description modified (diff)
Note: See TracTickets for help on using tickets.