Ticket #180 (closed defect: fixed)

Opened 07/07/08 20:50:47 (3 months ago)

Last modified 07/29/08 16:01:55 (2 months ago)

Manage Feedback: Action notification issues

Reported by: kimparsell Owned by: sidtheduck
Priority: low Milestone: 1.1
Component: Administration Version: 1.0b3
Severity: normal Keywords: has-patch needs-testing
Cc:

Description

I approve a comment, and I get the following:

You have approved 1 comment(s) successfully.

You have no user comments on your gallery.

The 2nd message is confusing, making it sound like there are no comments at all. In this instance it shouldn't appear, and the first message should be changed to read "You have approved 1 comment(s) successfully. There are no other new comments awaiting approval."

The "no user comments" message shows up other places in the Manage Feedback section where it shouldn't when trying to edit a comment, etc. The only time this message should appear is when there are no comments at all on the gallery.

Change History

Changed 07/22/08 01:42:55 (3 months ago) by sidtheduck

  • milestone changed from 1.0 to 1.1

Changed 07/28/08 16:28:28 (2 months ago) by sidtheduck

  • keywords has-patch needs-testing added

See ticket #185 for patch

Changed 07/28/08 17:31:13 (2 months ago) by kimparsell

Results of testing the patch from Ticket #185:

- Submitted a new comment, which went into the moderation queue.

- Opened Manage Feedback and clicked link at top for moderation queue.

- Test 1: I click the Approve image to the right of the pending comment, get the javascript confirmation message, and the comment is approved with the correct message being displayed.

- Test 2: I check the box to the left of the pending comment and click Approve Checked at the bottom. I'm taken back to the main Manage Feedback page with the message still at the top that I have 1 comment waiting for approval. I go to the queue, check the box, click Approve Checked, and get the same result. The comment isn't getting approved using this method.

Changed 07/28/08 17:37:15 (2 months ago) by kimparsell

Test 3: I can delete a comment in the moderation queue or an already approved comment using the Delete image link on the right, but I cannot delete a comment using the checkbox and Delete Checked button at the bottom of the page.

Changed 07/29/08 00:57:12 (2 months ago) by sidtheduck

Patch from ticket #185 updated. Should now work with clicking the check boxes (I missed a value for a hidden form input). Should work by clicking the Delete Checked or Approve Checked buttons or by using the 'x' and '+' image links for single images.

Changed 07/29/08 12:33:18 (2 months ago) by kimparsell

  • owner changed from mike to sidtheduck

I've just finished testing with the latest patch, and all the issues from yesterday have now been resolved. Approve and Delete functions work whether using the checkboxes/buttons or the X and + image links.

Changed 07/29/08 16:01:55 (2 months ago) by sidtheduck

  • status changed from new to closed
  • resolution set to fixed

Fixed with r569.

Note: See TracTickets for help on using tickets.