Ticket #192 (closed defect: fixed)

Opened 3 months ago

Last modified 3 months ago

  being added to caption / desciption for AJAX editing

Reported by: sidtheduck Owned by: sidtheduck
Priority: normal Milestone: 1.1
Component: General Version: 1.0b3
Severity: normal Keywords:
Cc:

Description

A stubborn   is being added to the caption / description which causes a square to be rendered when using translations (see here). This should be fixed.

Attachments

ajax_edit_remove_space.patch (12.1 KB) - added by sidtheduck 3 months ago.

Change History

Changed 3 months ago by sidtheduck

  • status changed from new to testing

I added a patch for revision 573 that I believe will fix the issue. For some reason, an   character was being encoded as %C2%A0 when the ajax_editing javascript pulls the innerHTML from the div and places it in the textarea for editing.

Changed 3 months ago by kimparsell

I've tested the patch, and it is working fine for me on the Manage page. I did find another hard-coded   character in plog-feedback.php, line 232 that will need to be removed from that file, and code generated to take care of it as well for the Feedback page.

Changed 3 months ago by ryanduff

  • status changed from testing to assigned

We've obviously missed the root cause of this bug since its popping up in another spot too.

Changed 3 months ago by sidtheduck

Changed 3 months ago by sidtheduck

  • status changed from assigned to testing

I re-uploaded a newer patch addressing the additional space in plog-feedback.php

Changed 3 months ago by sidtheduck

Regarding it "popping up" in another spot, the fixed javascript was taking care of the extraneous  . However, the php was not generating an   when first navigating to the page if a field was blank. The fixed javascript was working fine, but without the   code there, the layout was shrinking, making it hard to click the field for editing. The new patch should remedy that.

Changed 3 months ago by kimparsell

I've tested the 2nd patch, and the additional issue in plog-feedback.php has now been resolved.

Changed 3 months ago by sidtheduck

  • status changed from testing to commit

Changed 3 months ago by sidtheduck

  • status changed from commit to closed
  • resolution set to fixed

Should be fixed in revision r574 (committed attached patch)

Note: See TracTickets for help on using tickets.